[OpenCL] Introduce OpenCL wrapper to TVM #13362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
echuraev
force-pushed
the
echuraev/libopencl_wrapper
branch
from
548d1cf to
fb3f5a6
Compare
echuraev
force-pushed
the
echuraev/libopencl_wrapper
branch
from
fb3f5a6 to
6614443
Compare
Member
|
@elvin-n Can you review this? |
echuraev
force-pushed
the
echuraev/libopencl_wrapper
branch
from
446941f to
8ecacf8
Compare
elvin-n
reviewed
Nov 14, 2022
csullivan
approved these changes
Nov 14, 2022
Comment on lines
20
to
24
| /*! | ||
| * \file opencl_wrapper.cc | ||
| */ |
Contributor
There was a problem hiding this comment.
Can we note the version of opencl for which this wrapper is applicable?
Contributor
Author
There was a problem hiding this comment.
Added information about OpenCL version. Currently, this wrapper is applicable for OpenCL 1.2. Because it is version which is used in TVM. But we can easily uplift this version, then it will be necessary.
elvin-n
suggested changes
Nov 14, 2022
Contributor
Author
|
@tvm-bot rerun |
elvin-n
suggested changes
Nov 15, 2022
Contributor
Author
|
@tvm-bot rerun |
This wrapper helps dynamically loading OpenCL library. It allows us to avoid of looking for and copying OpenCL library to host, looking for OpenCL SDK.
Also, use OpenCL wrapper by default and fix Windows build
echuraev
force-pushed
the
echuraev/libopencl_wrapper
branch
from
0df05af to
0453286
Compare
elvin-n
approved these changes
Nov 15, 2022
Contributor
|
We discussed this in the TVM community meeting this morning. Here are notes:
|
echuraev
added a commit
to echuraev/tvm
that referenced
this pull request
Nov 18, 2022
As it was mentioned in apache#13362, it would be nice to add check when the user is using a version of libOpenCL.so that is too old. In this PR we introduce this functionality. In the `init` method, we traverse through all OpenCL devices and check their version. If the version is older than the target version in TVM, then we notify the user that we will skip this device. We cannot throw any exception from method `init` because it is possible that you have compiled host code with OpenCL support, but the host device won't have any OpenCL device which is supported by TVM (e.g. they all have too old version of libOpenCL.so). From OpenCL codegen we call function OpenCLModuleCreate. In the OpenCLModuleCreate init function might be called and in this case an exception will be generated on the host side although that the target device might be supported by TVM. This is why we don't throw any exceptions in the init function. If in the runtime we use some OpenCL methods and the list of the devices is empty, then we will generate an exception and notify user that possible reason is because version of libOpenCL.so is too old.
echuraev
added a commit
to echuraev/tvm
that referenced
this pull request
Nov 18, 2022
As it was mentioned in apache#13362, it would be nice to add check when the user is using a version of libOpenCL.so that is too old. In this PR we introduce this functionality. In the `init` method, we traverse through all OpenCL devices and check their version. If the version is older than the target version in TVM, then we notify the user that we will skip this device. We cannot throw any exception from method `init` because it is possible that you have compiled host code with OpenCL support, but the host device won't have any OpenCL device which is supported by TVM (e.g. they all have too old version of libOpenCL.so). From OpenCL codegen we call function OpenCLModuleCreate. In the OpenCLModuleCreate init function might be called and in this case an exception will be generated on the host side although that the target device might be supported by TVM. This is why we don't throw any exceptions in the init function. If in the runtime we use some OpenCL methods and the list of the devices is empty, then we will generate an exception and notify user that possible reason is because version of libOpenCL.so is too old.
echuraev
added a commit
to echuraev/tvm
that referenced
this pull request
Nov 18, 2022
As it was mentioned in apache#13362, it would be nice to add check when the user is using a version of libOpenCL.so that is too old. In this PR we introduce this functionality. In the `init` method, we traverse through all OpenCL devices and check their version. If the version is older than the target version in TVM, then we notify the user that we will skip this device. We cannot throw any exception from method `init` because it is possible that you have compiled host code with OpenCL support, but the host device won't have any OpenCL device which is supported by TVM (e.g. they all have too old version of libOpenCL.so). From OpenCL codegen we call function OpenCLModuleCreate. In the OpenCLModuleCreate init function might be called and in this case an exception will be generated on the host side although that the target device might be supported by TVM. This is why we don't throw any exceptions in the init function. If in the runtime we use some OpenCL methods and the list of the devices is empty, then we will generate an exception and notify user that possible reason is because version of libOpenCL.so is too old.
masahi
pushed a commit
that referenced
this pull request
Nov 18, 2022
As it was mentioned in #13362, it would be nice to add check when the user is using a version of libOpenCL.so that is too old. In this PR we introduce this functionality. In the `init` method, we traverse through all OpenCL devices and check their version. If the version is older than the target version in TVM, then we notify the user that we will skip this device. We cannot throw any exception from method `init` because it is possible that you have compiled host code with OpenCL support, but the host device won't have any OpenCL device which is supported by TVM (e.g. they all have too old version of libOpenCL.so). From OpenCL codegen we call function OpenCLModuleCreate. In the OpenCLModuleCreate init function might be called and in this case an exception will be generated on the host side although that the target device might be supported by TVM. This is why we don't throw any exceptions in the init function. If in the runtime we use some OpenCL methods and the list of the devices is empty, then we will generate an exception and notify user that possible reason is because version of libOpenCL.so is too old.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [OpenCL] Introduce OpenCL wrapper to TVM This wrapper helps dynamically loading OpenCL library. It allows us to avoid of looking for and copying OpenCL library to host, looking for OpenCL SDK. * Update apps and documentation * Apply comments * Apply comments and fix Android build Also, use OpenCL wrapper by default and fix Windows build * Apply comments * Update LICENSE file
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
As it was mentioned in apache#13362, it would be nice to add check when the user is using a version of libOpenCL.so that is too old. In this PR we introduce this functionality. In the `init` method, we traverse through all OpenCL devices and check their version. If the version is older than the target version in TVM, then we notify the user that we will skip this device. We cannot throw any exception from method `init` because it is possible that you have compiled host code with OpenCL support, but the host device won't have any OpenCL device which is supported by TVM (e.g. they all have too old version of libOpenCL.so). From OpenCL codegen we call function OpenCLModuleCreate. In the OpenCLModuleCreate init function might be called and in this case an exception will be generated on the host side although that the target device might be supported by TVM. This is why we don't throw any exceptions in the init function. If in the runtime we use some OpenCL methods and the list of the devices is empty, then we will generate an exception and notify user that possible reason is because version of libOpenCL.so is too old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrapper helps dynamically loading OpenCL library. It allows us to avoid of looking for and copying OpenCL library to host, looking for OpenCL SDK.
cc: @elvin-n, @masahi, @csullivan