-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Lint] Fix import in test_tvmscript_type.py #13367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
driazati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks relatively harmless but why wasn't this caught in CI / tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm curious too, but it's good that we caught it now
|
Would you mind sharing the error message from the linter? Thanks! |
It was a python module not found error. I ran the linter locally using the docker image and, strangely am no longer able to reproduce it |
|
Perhaps it could be some caching issues |
|
hey what shall we do with this PR? probably we could close if the issue is not longer reproducible? |
Agree to close it. |
#12496 does not patch an import that caused the linter to fail. This PR fixes it.
@driazati