Skip to content

Conversation

@gigiblender
Copy link
Contributor

#12496 does not patch an import that caused the linter to fail. This PR fixes it.

@driazati

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: lint See #10317 for details
  • Built docs for commit 4469d1b can be found here.
  • This PR had no significant effect on CI runtime: -5.86% (167.4m -> 157.59m)

Generated by tvm-bot

Copy link
Member

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks relatively harmless but why wasn't this caught in CI / tests?

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm curious too, but it's good that we caught it now

@junrushao
Copy link
Member

Would you mind sharing the error message from the linter? Thanks!

@gigiblender
Copy link
Contributor Author

Would you mind sharing the error message from the linter? Thanks!

It was a python module not found error. I ran the linter locally using the docker image and, strangely am no longer able to reproduce it

@junrushao
Copy link
Member

Perhaps it could be some caching issues

@junrushao
Copy link
Member

hey what shall we do with this PR? probably we could close if the issue is not longer reproducible?

@gigiblender
Copy link
Contributor Author

hey what shall we do with this PR? probably we could close if the issue is not longer reproducible?

Agree to close it.

@gigiblender gigiblender deleted the lint-fix branch November 16, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants