Skip to content

Conversation

@nverke
Copy link
Contributor

@nverke nverke commented Nov 14, 2022

Adding in a test that covers another case that can happen when running a check in reducer.cc here.

cc @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented Nov 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested a review from junrushao November 14, 2022 17:15
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the unittest!

@junrushao junrushao merged commit a042a93 into apache:main Nov 16, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
@nverke nverke deleted the add_reducer_test branch January 13, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants