[MetaSchedule] Fix segfault in gradient based scheduler #13399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
yelite
force-pushed
the
fix-gradient-based-scheduler-on-empty-candidates
branch
from
bea9ff2 to
a205f93
Compare
Hzfengsy
approved these changes
Nov 16, 2022
zxybazh
approved these changes
Nov 16, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks for spotting these corner cases. I happen to notice a similar issue when the search strategy direcly returns None. Can you please also fix that?
Gradient based scheduler would segfault if no candidates can be returned by the search strategy for some workload. It's expected to tune other workloads that have candidates.
yelite
force-pushed
the
fix-gradient-based-scheduler-on-empty-candidates
branch
from
a205f93 to
f8a7714
Compare
Member
|
LGTM, good to merge once CI passed : ) |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Fix segfault in gradient based scheduler Gradient based scheduler would segfault if no candidates can be returned by the search strategy for some workload. It's expected to tune other workloads that have candidates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradient based scheduler would segfault if no candidates can be returned by the search strategy for some workload. It's expected that the scheduler continues to tune other workloads that have candidates.
cc: @zxybazh @junrushao