[CMSIS-NN] Support for int16 in fully connected layer #13484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for int16 fully_connected via CMSIS-NN -Pattern matching and RelatToTIR introduce int16 support -Added int16 variants to fully_connected tests
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
asparkhi
reviewed
Nov 24, 2022
Contributor
asparkhi
left a comment
asparkhi
left a comment
There was a problem hiding this comment.
Thanks for the changes @neildhickey :) Looks great overall. Just a nit and a request.
| fc_call = requantize_input; | ||
| } | ||
|
|
||
| int32_t dtype_bits = fc_call->args[0]->type_as<TensorTypeNode>()->dtype.bits(); |
| } else { | ||
| clip_min = -128; | ||
| clip_max = 127; | ||
| clip_min = -static_cast<int>(1 << dtype_bits); |
Contributor
There was a problem hiding this comment.
Could you please also have a look at
. Looks incorrect there in the Conv2D implementation.
Contributor
asparkhi
approved these changes
Nov 25, 2022
Contributor
asparkhi
left a comment
asparkhi
left a comment
There was a problem hiding this comment.
Thanks @neildhickey for addressing the comments. Congratulations on the first TVM PR 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for int16 fully_connected via CMSIS-NN
-Pattern matching and RelayToTIR introduce int16 support
-Added int16 variants to fully_connected tests