[CodegenC] Explicit forward function declarations #13522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Mousius
reviewed
Nov 30, 2022
Mousius
reviewed
Nov 30, 2022
tests/python/contrib/test_cmsisnn/test_forward_function_declarations.py
Outdated
Show resolved
Hide resolved
Mousius
reviewed
Nov 30, 2022
tests/python/contrib/test_cmsisnn/test_forward_function_declarations.py
Outdated
Show resolved
Hide resolved
asparkhi
force-pushed
the
explicit_function_declaration
branch
3 times, most recently
from
b214f65 to
0f4898a
Compare
Mousius
requested changes
Dec 5, 2022
|
|
||
|
|
||
| def skip_if_no_reference_system(func): | ||
| return tvm.testing.skip_if_32bit(reason="Reference system unavailable in i386 container")(func) |
Member
There was a problem hiding this comment.
Can we use @tvm.testing.requires_corstone300 instead?
asparkhi
force-pushed
the
explicit_function_declaration
branch
2 times, most recently
from
e46b0e7 to
4f3db7a
Compare
armclang 6.19 does not support implicit function declarations. This commit adds support for generating forward function declarations in the C file generated for __tvm_main__. All the non-pure extern functions called from __tvm_main__ will be declared explicitly in this file. Change-Id: I03b12e6c844911bd7edb6e42ddd2b17f066bd0fa
asparkhi
force-pushed
the
explicit_function_declaration
branch
from
4f3db7a to
23619e7
Compare
Mousius
approved these changes
Dec 7, 2022
Member
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
LGTM @ashutosh-arm! Thanks for all the updates 😸
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
armclang 6.19 emits an error for implicit function declarations. This commit adds support for generating forward function declarations in the C file generated for __tvm_main__. All the non-pure extern functions called from __tvm_main__ will be declared explicitly in this file.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
armclang 6.19 emits an error for implicit function declarations. This commit adds support for generating forward function declarations in the C file generated for __tvm_main__. All the non-pure extern functions called from __tvm_main__ will be declared explicitly in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
armclang 6.19 does not support implicit function declarations. This commit adds support for generating forward function declarations in the C file generated for tvm_main.
cc @Mousius @lhutton1