[OpenCL] Introduction of weights on buffers #13563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
echuraev
reviewed
Dec 6, 2022
Contributor
echuraev
left a comment
echuraev
left a comment
There was a problem hiding this comment.
In general LGTM. Several minor comments
| std::string scope = Scope(ttype->shape, GetVirtualDevice(GetRef<Expr>(call))); | ||
| if (expr_attrib.as<Conv2DAttrs>() || expr_attrib.as<Conv2DWinogradAttrs>()) | ||
| { | ||
| if ((i == 1) && |
Contributor
There was a problem hiding this comment.
nit: Create local variable, e.g.: const int weights_pos = 1;.
|
|
||
| for (auto& arg : call->args) { | ||
| Visit(arg); | ||
| if (std::find(buffers_args.begin(), buffers_args.end(), arg) == buffers_args.end()) |
Contributor
There was a problem hiding this comment.
nit: Probably we can change type of buffers_args to unordered_set? In this case, the search should be faster.
The same comment for buffers_params.
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* introduced support for weights on buffers * update winograd schedule for support buffers on weights * Updated the logic of using buffers * Update texture annotation pass * now weights on buffers support only in fp32 case * update opencl tests for weights on buffers * fix lint * fix lint * fix lint * apply comments * fix lint * fix lint
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
* introduced support for weights on buffers * update winograd schedule for support buffers on weights * Updated the logic of using buffers * Update texture annotation pass * now weights on buffers support only in fp32 case * update opencl tests for weights on buffers * fix lint * fix lint * fix lint * apply comments * fix lint * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the use of convolution weights on buffers rather than textures.