Skip to content

Conversation

@vinx13
Copy link
Member

@vinx13 vinx13 commented Dec 6, 2022

LegalizeIndexMapDType previously ignore pre-defined inverse map, which causes error in TransformLayout when the inverse index map is predefined but the arithmetic analysis fails to compute the inverse map.

cc @masahi @Lunderberg

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 6, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from Lunderberg and masahi December 6, 2022 19:04
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinx13 vinx13 force-pushed the fix/layout-rewrite-i64 branch from f1498c9 to 6f726f9 Compare December 6, 2022 19:23
@mehrdadh
Copy link
Member

mehrdadh commented Dec 6, 2022

Please rebase because of 9374738

@vinx13 vinx13 force-pushed the fix/layout-rewrite-i64 branch from 6f726f9 to ceaca31 Compare December 6, 2022 23:15
@vinx13 vinx13 merged commit 3e42506 into apache:main Dec 7, 2022
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants