Skip to content

Conversation

@kparzysz-quic
Copy link
Contributor

@kparzysz-quic kparzysz-quic commented Dec 8, 2022

Don't fail the test for reasons that are unrelated to the feature being tested.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 8, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@kparzysz-quic
Copy link
Contributor Author

@tvm-bot rerun

@mehrdadh
Copy link
Member

mehrdadh commented Dec 8, 2022

@kparzysz-quic this could silently skip the test which happened before in the CI. Could you please explain why you need this? If you are running this in a different CI and you don't want this test to run, I think you can filter it in the pytest

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kparzysz-quic

@leandron leandron merged commit fbb31fe into apache:main Dec 9, 2022
@kparzysz-quic kparzysz-quic deleted the pyt3 branch January 10, 2023 16:29
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants