[LLVM] Fix get tm allow_missing check pos #13591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
| llvm_instance->createTargetMachine(triple_, cpu_, GetTargetFeatureString(), target_options_, | ||
| reloc_model_, code_model_, opt_level_); | ||
| target_machine_ = std::unique_ptr<llvm::TargetMachine>(tm); | ||
| if (!allow_missing) { |
Contributor
There was a problem hiding this comment.
This is the only place where target_machine_ is assigned a value, so this check was actually sufficient.
Edit: the change doesn't break anything, so it can stay.
Contributor
Author
There was a problem hiding this comment.
Emmmm but when llvm::TargetRegistry::lookupTarget(triple_, error) failed，the target_machine_ is also nullptr,
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
Fix get tm allow_missing check pos
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
Fix get tm allow_missing check pos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
GetOrCreateTargetMachine's failure check would be out oflookupTarget' nest scope.