Skip to content

Conversation

@kparzysz-quic
Copy link
Contributor

Pass std::nullopt to initialization of PassBuilder for PGOOptions. LLVM is moving away from its own Optional type to std::optional.

Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`.
LLVM is moving away from its own `Optional` type to `std::optional`.
@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: llvm See #10317 for details

Generated by tvm-bot

2 similar comments
@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: llvm See #10317 for details

Generated by tvm-bot

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 14, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: llvm See #10317 for details

Generated by tvm-bot

Copy link
Contributor

@Icemist Icemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks backward compatible because llvm::Optional<T> has a constructor from std::nullopt_t.

It is about this change in the main branch:
LLVM::Optional<PGOOptions> PGOOpt = LLVM::None,
=>
std::optional<PGOOptions> PGOOpt = std::nullopt,

@masahi masahi merged commit 496ca9a into apache:main Dec 15, 2022
@kparzysz-quic kparzysz-quic deleted the pgoopt branch January 10, 2023 16:28
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`.
LLVM is moving away from its own `Optional` type to `std::optional`.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Pass `std::nullopt` to initialization of `PassBuilder` for `PGOOptions`.
LLVM is moving away from its own `Optional` type to `std::optional`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants