Skip to content

Conversation

@cyx-6
Copy link
Contributor

@cyx-6 cyx-6 commented Jan 3, 2023

This pr fixs the missing check when assigning a PackedFunc into TVMRetValue.
For, example,

TVMRetValue value;
ObjectRef obj = some_packed_func;
value = obj; // Fails here
^^^^^^^^^^^
value.operator PackedFunc()

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@tqchen tqchen merged commit 45a8a44 into apache:main Jan 3, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* Add missing check for `PackedFunc`

* delete duplicated line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants