-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TIR][Arith] Add common sub expr analyzer #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
3b169c3 to
bdb9e46
Compare
bdb9e46 to
5d77b51
Compare
Hzfengsy
approved these changes
Jan 6, 2023
Member
Hzfengsy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [TIR][Arith] Add common sub expr analyzer * Update python/tvm/arith/pattern.py Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Update src/arith/detect_common_subexpr.cc Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Update python/tvm/arith/pattern.py Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Update python/tvm/arith/pattern.py Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Update src/arith/detect_common_subexpr.cc Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn> * Update detect_common_subexpr.cc * Update pattern.py * Update pattern.py * Update pattern.py * Update pattern.py Co-authored-by: Min Chen <chen.min@intellif.com> Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an arith helper interface to analyze common sub expression.
Also modify InsertVectorToSortedSemanticComputations to be aware of the occurrence times.
cc @Hzfengsy @wrongtest-intellif