Skip to content

[Adreno] Update interface of AnnotateMemoryScope pass #13779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echuraev merged 1 commit into from
Jan 19, 2023
Merged

[Adreno] Update interface of AnnotateMemoryScope pass #13779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/tvm/relay/transform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ TVM_DLL Pass CapturePostDfsIndexInSpans();
* \brief Calls device dependent memory scope analysis pass, collects mapping of desirable
* expr->memory_scope and annotates expressions by VirtualDevice with required memory_scope
*/
TVM_DLL Pass AnnotateMemoryScope(CompilationConfig config);
TVM_DLL Pass AnnotateMemoryScope();

/*!
* \brief Removes non-fused reshapes after lowering the graph.
Expand Down
2 changes: 1 addition & 1 deletion src/relay/backend/build_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ class RelayBuildModule : public runtime::ModuleNode {
relay_module = transform::Inline()(relay_module);
relay_module = transform::InferType()(relay_module);
relay_module = transform::LabelOps()(relay_module);
relay_module = transform::AnnotateMemoryScope(config_)(relay_module);
relay_module = transform::AnnotateMemoryScope()(relay_module);

ICHECK(relay_module.defined());

Expand Down
8 changes: 4 additions & 4 deletions src/relay/transforms/annotate_texture_storage.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ Map<Expr, Map<Expr, Array<String>>> CollectStorageInfo(const Expr& expr) {
return storage_info;
}

Expr AnnotateMemoryScopeExpr(const Expr& expr, const IRModule& mod, CompilationConfig config) {
Expr AnnotateMemoryScopeExpr(const Expr& expr, const IRModule& mod) {
auto storage_scope = CollectStorageInfo(expr);
if (storage_scope.size()) {
return RewriteVDStorageScopes(storage_scope).Rewrite(expr);
Expand All @@ -655,10 +655,10 @@ Expr AnnotateMemoryScopeExpr(const Expr& expr, const IRModule& mod, CompilationC
}

namespace transform {
tvm::transform::Pass AnnotateMemoryScope(CompilationConfig config) {
tvm::transform::Pass AnnotateMemoryScope() {
runtime::TypedPackedFunc<Function(Function, IRModule, PassContext)> pass_func =
[config = std::move(config)](Function f, IRModule m, PassContext pc) {
return Downcast<Function>(AnnotateMemoryScopeExpr(f, m, config));
[](Function f, IRModule m, PassContext pc) {
return Downcast<Function>(AnnotateMemoryScopeExpr(f, m));
};
return CreateFunctionPass(pass_func, 2, "AnnotateMemoryScope", {});
}
Expand Down