[microNPU] Add rescale parameters for binary elementwise #13890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rescale parameters have been added for binary elementwise operation in accordance with the Vela API (rescale field in NpuElementWiseOperation https://review.mlplatform.org/plugins/gitiles/ml/ethos-u/ethos-u-vela/+/refs/tags/3.5.0/ethosu/vela/api.py#381). This PR is preparation for implementation of softmax operation.
Collaborator
lhutton1
reviewed
Feb 6, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
LGTM, just had a couple of nit picks :)
python/tvm/relay/backend/contrib/ethosu/op/binary_elementwise.py
Outdated
Show resolved
Hide resolved
python/tvm/relay/backend/contrib/ethosu/op/binary_elementwise.py
Outdated
Show resolved
Hide resolved
python/tvm/relay/backend/contrib/ethosu/te/binary_elementwise.py
Outdated
Show resolved
Hide resolved
lhutton1
approved these changes
Feb 6, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @alexey-yazev, LGTM!
Contributor
|
Thanks @alexey-yazev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescale parameters have been added for binary elementwise operation in accordance with the Vela API (rescale field in NpuElementWiseOperation https://review.mlplatform.org/plugins/gitiles/ml/ethos-u/ethos-u-vela/+/refs/tags/3.5.0/ethosu/vela/api.py#381). This PR is preparation for implementation of softmax operation.
cc @leandron, @ekalda, @lhutton1