[ETHOSN] Support for addition with constant input #13931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After NPU driver 22.11 update, constants can be provided as inputs to addition operator. This commit traverses constants to update operand entries for it and adds tests to verify these cases. Co-authored-by: Luke Hutton <luke.hutton@arm.com> Change-Id: If29b99abea07320af6309b127698b757d6787e29
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Change-Id: I49a38176a2f30223ff4309afdc81b3efcdec5517
lhutton1
reviewed
Feb 8, 2023
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Just a couple of small things :)
Change-Id: I066246bc6afcd580fc9b501f09f8ed31c6049470
lhutton1
approved these changes
Feb 9, 2023
Contributor
|
Thanks @ashutosh-arm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After NPU driver 22.11 update, constants can be provided as inputs to addition operator.
This commit traverses constants to update operand entries for it and adds tests to verify these cases.
cc @lhutton1