[Diagnostic] Support constructing Diagnostic Error through ObjectRef #13977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR supports creating a diagnostic error from an arbitrary Object. Given that we are bringing the diagnostic error for general uses in the long term, in which case * not every Expr necessarily has a span, * we have well-implemented elegant location-aware printer for an object itself, * we may need to print some object other than Expr, or does even not have a span field, we support diagnostic error with arbitrary object to denote the location. Co-authored-by: Tianqi Chen <tianqi.tchen@gmail.com>
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
@tvm-bot rerun |
1 similar comment
Contributor
Author
|
@tvm-bot rerun |
Hzfengsy
approved these changes
Feb 14, 2023
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Feb 14, 2023
…pache#13977) This PR supports creating a diagnostic error from an arbitrary Object. Given that we are bringing the diagnostic error for general uses in the long term, in which case * not every Expr necessarily has a span, * we have well-implemented elegant location-aware printer for an object itself, * we may need to print some object other than Expr, or does even not have a span field, we support diagnostic error with arbitrary object to denote the location. Co-authored-by: Tianqi Chen <tianqi.tchen@gmail.com>
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Feb 14, 2023
…pache#13977) This PR supports creating a diagnostic error from an arbitrary Object. Given that we are bringing the diagnostic error for general uses in the long term, in which case * not every Expr necessarily has a span, * we have well-implemented elegant location-aware printer for an object itself, * we may need to print some object other than Expr, or does even not have a span field, we support diagnostic error with arbitrary object to denote the location. Co-authored-by: Tianqi Chen <tianqi.tchen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports creating a diagnostic error from an arbitrary Object.
Given that we are bringing the diagnostic error for general uses in the long term, in which case
we support diagnostic error with arbitrary object to denote the location.
Co-authored-by: Tianqi Chen tianqi.tchen@gmail.com