Skip to content

Conversation

@shtinsa
Copy link
Contributor

@shtinsa shtinsa commented Feb 15, 2023

This PR fixes internal object initialization in EvolutionarySearchNode::State class. Unfortunately there is no way to prepare test case.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 15, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@shtinsa shtinsa changed the title [Metaschedule] EvolutionarySearchNode::State constructor typo fix. [Metaschedule] EvolutionarySearchNode::State constructor typo fix Feb 15, 2023
@shtinsa
Copy link
Contributor Author

shtinsa commented Feb 15, 2023

@tvm-bot rerun

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shtinsa ,

It looks like the CI is failing because your PR has no description, could you please add one as well as a test case to demonstrate the issue this fixes?

@shtinsa
Copy link
Contributor Author

shtinsa commented Feb 15, 2023

@tvm-bot rerun

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shtinsa
Copy link
Contributor Author

shtinsa commented Feb 16, 2023

Hi @shtinsa ,

It looks like the CI is failing because your PR has no description, could you please add one as well as a test case to demonstrate the issue this fixes?

Unfortunately it is a problem to create test.

@junrushao
Copy link
Member

junrushao commented Feb 16, 2023

To be clear, this is not possible to create a test, as the code itself is a type, rather than a bug that leads to segfault or exceptions

@Mousius
Copy link
Member

Mousius commented Feb 16, 2023

@shtinsa / @junrushao - I've tested similar things in the past, as far as I can see this is simply ensuring a more precise allocation which should be testable. Alas, TVM does not have good testing practices so I don't think there's an easy way forward. Thanks for the contribution @shtinsa, hope it doesn't unfix itself in future 😸

@Mousius Mousius merged commit aa927df into apache:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants