-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[TORCH] scatter_reduce implementation #14018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
@tvm-bot rerun |
Contributor
Author
|
@tvm-bot rerun |
08b75d0 to
71e5b03
Compare
Contributor
Author
|
Hello @shingjan, @yelite and @AndrewZhaoLuo! Could you all review this PR? |
KJlaccHoeUM9l
approved these changes
Feb 22, 2023
Contributor
KJlaccHoeUM9l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
masahi
approved these changes
Feb 22, 2023
yongwww
pushed a commit
to yongwww/tvm
that referenced
this pull request
Feb 27, 2023
* add scatter_reduce to pytorch front-end * test for scatter_reduce was added to pytorch CI * update check * add TODOs waiting for other PRs for development * fix lint * fix min-max reduction for cpu * final clean code --------- Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scatter_reduce operation was implemented on pytorch front-end. Test was added to CI for it.
Note:
meanreduction is not supported, but will be when other PRs related to scatter-like operations will be merged.