Skip to content

Conversation

@vvchernov
Copy link
Contributor

@vvchernov vvchernov commented Feb 17, 2023

scatter_reduce operation was implemented on pytorch front-end. Test was added to CI for it.
Note: mean reduction is not supported, but will be when other PRs related to scatter-like operations will be merged.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 17, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@vvchernov
Copy link
Contributor Author

@tvm-bot rerun

@vvchernov
Copy link
Contributor Author

@tvm-bot rerun

@vvchernov vvchernov force-pushed the vc/pytorch_scatter_reduce branch from 08b75d0 to 71e5b03 Compare February 22, 2023 06:53
@vvchernov
Copy link
Contributor Author

Hello @shingjan, @yelite and @AndrewZhaoLuo! Could you all review this PR?

Copy link
Contributor

@KJlaccHoeUM9l KJlaccHoeUM9l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit 3cdb079 into apache:main Feb 22, 2023
@vvchernov vvchernov deleted the vc/pytorch_scatter_reduce branch February 22, 2023 19:59
yongwww pushed a commit to yongwww/tvm that referenced this pull request Feb 27, 2023
* add scatter_reduce to pytorch front-end

* test for scatter_reduce was added to pytorch CI

* update check

* add TODOs waiting for other PRs for development

* fix lint

* fix min-max reduction for cpu

* final clean code

---------

Co-authored-by: Valery Chernov <valery.chernov@deelvin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants