[FIX][TOPI] Clip with IntImm/FloatImm #14027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
vinx13
approved these changes
Feb 17, 2023
MasterJH5574
force-pushed
the
tvm-dev/2023-02-17-topi-clip
branch
from
5ab1a13 to
55708ea
Compare
Prior to this PR, TOPI clip op only accepts the min/max values with Python native float/int type, and rejects FloatImm and IntImm. This PR enhances the clip op to allow it accept FloatImm and IntImm. Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
MasterJH5574
force-pushed
the
tvm-dev/2023-02-17-topi-clip
branch
from
55708ea to
0e8bc14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, TOPI clip op only accepts the min/max values with Python native float/int type, and rejects FloatImm and IntImm.
This PR enhances the clip op to allow it accept FloatImm and IntImm.
Co-authored-by: Siyuan Feng Hzfengsy@sjtu.edu.cn