Skip to content

Conversation

@tqchen
Copy link
Member

@tqchen tqchen commented Feb 20, 2023

This PR address fixes for UMA target registration.

Changes:

  • Incorporates all proposed fixes from mentioned PR #12731
  • Address test case concerns and discussions from PR #12731
  • NEW: Already exiting target cannot be created, explicit error on this.
  • NEW: Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Feb 20, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: bugfix, uma See #10317 for details

Generated by tvm-bot

@tqchen
Copy link
Member Author

tqchen commented Feb 20, 2023

cherrypick of #13624

This PR address fixes for UMA target registration.
* Fix the doc issue apache#13304
* Continues stalled PR apache#12731

Changes:
* Incorporates all proposed fixes from mentioned [PR apache#12731](apache#12731)
* Address test case concerns and discussions from [PR apache#12731](apache#12731)
* **NEW:** Already exiting target cannot be created, explicit error on this.
* **NEW:** Attributes having special/reserved scope cannot be created explicitly.

It also address proper test cases for all the above.

Signed-off-by: tqchen <tianqi.tchen@gmail.com>
Co-authored-by: Balint Cristian <cristian.balint@gmail.com>
@tqchen tqchen merged commit 9bc6532 into apache:v0.11.0 Feb 20, 2023
@tqchen tqchen mentioned this pull request Feb 20, 2023
7 tasks
@tqchen tqchen deleted the v011cherry branch February 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants