Skip to content

[Frontend][Paddle]fix eye and dist #14292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masahi merged 1 commit into from
Mar 15, 2023
Merged

[Frontend][Paddle]fix eye and dist #14292

masahi merged 1 commit into from
Mar 15, 2023

Conversation

@XG-zheng
Copy link
Contributor

@XG-zheng XG-zheng commented Mar 14, 2023

Remove redundant abs op for dist.
Cover the case where num_columns is equal -1 for eye.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 14, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

heliqi
heliqi approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@heliqi heliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahi masahi merged commit 075e2ec into apache:main Mar 15, 2023
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahi masahi masahi approved these changes

+1 more reviewer

@heliqi heliqi heliqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XG-zheng @tvm-bot @masahi @heliqi