Skip to content

Conversation

@quic-sanirudh
Copy link
Contributor

LLVM upstream recently changed their API for registerCallbacks in https://reviews.llvm.org/D146160 and this causes an error while building

LLVM upstream recently changed their API for registerCallbacks in
https://reviews.llvm.org/D146160 and this causes an error while building
@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 17, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: llvm See #10317 for details

Generated by tvm-bot

@quic-sanirudh
Copy link
Contributor Author

cc @kparzysz-quic

Copy link
Contributor

@kparzysz-quic kparzysz-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kparzysz-quic kparzysz-quic merged commit f7c2bbb into apache:main Mar 17, 2023
@LRY89757
Copy link
Contributor

Are you sure that this api has changed since the version 17.0.0? I used your version to compile tvm with llvm 17.0.0, but failed. When I use the fam instead of the mam, it runs smoothly.

@kparzysz-quic
Copy link
Contributor

Version 17 of LLVM at this moment refers to the main branch of it. If you refresh your sources of LLVM, you will get the changes that this patch reflects.

@quic-sanirudh quic-sanirudh deleted the fix_llvm_si_callback_api branch November 15, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants