Skip to content

[Hexagon] Allow scalar tensors to have null shape during allocation #14376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csullivan merged 2 commits into from
Mar 23, 2023
Merged

[Hexagon] Allow scalar tensors to have null shape during allocation #14376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07679d9
[Hexagon] Allow scalar tensors to have null shape during allocation.
janetsc Mar 23, 2023
9504ee4
Add unit test for new case (scalar and null shape)
janetsc Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/hexagon/hexagon_device_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ void HexagonDeviceAPI::GetAttr(Device dev, DeviceAttrKind kind, TVMRetValue* rv)
// DataSpace: static allocations for Hexagon
void* HexagonDeviceAPI::AllocDataSpace(Device dev, int ndim, const int64_t* shape, DLDataType dtype,
Optional<String> mem_scope) {
CHECK(shape) << "shape array is null";
CHECK(shape || ndim == 0) << "shape array is null for a non-scalar tensor, ndim = " << ndim;
CHECK(IsValidDevice(dev)) << "dev.device_type: " << dev.device_type;

// IMPORTANT NOTE!
Expand Down
3 changes: 3 additions & 0 deletions tests/cpp-runtime/hexagon/hexagon_device_api_tests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,9 @@ TEST_F(HexagonDeviceAPITest, alloc_scalar) {

void* hexscalar = hexapi->AllocDataSpace(hex_dev, 0, new int64_t, int8, global_vtcm_scope);
CHECK(hexscalar != nullptr);

hexscalar = hexapi->AllocDataSpace(hex_dev, 0, nullptr, int8, global_vtcm_scope);
CHECK(hexscalar != nullptr);
}

// alloc and free of the same buffer on different devices should throw
Expand Down