[Rewrite] Fix rewriting division to constant to handle vector case #14382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
tkonolige
reviewed
Mar 24, 2023
| return post; | ||
| } | ||
|
|
||
| // rely on constant folding to fold things |
Contributor
There was a problem hiding this comment.
Are you sure constant folding is going to fire at the right time? I can't remember if the divisions need to be rewritten before FakeQuantization or if it doesn't matter when.
Contributor
Author
There was a problem hiding this comment.
Hmm good point, I think there is a way to specify a required pass to be run after this one, so maybe will try to figure that out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only handle scalar case. That is rewriting
a ./ 5 --> a .* 0.2. Now handle vector casea ./ [2, 3, 4] --> a .* [0.5, 0.33, 0.25]Also changes the pass to rely on constant folding for proper folding instead of manually constructing constant data.
cc @Johnson9009 @tkonolige