Skip to content

Conversation

@psrivas2
Copy link
Contributor

@psrivas2 psrivas2 commented Mar 28, 2023

Fix a bug where a block could have no stores, the pass crashes in such a case. We should mark the PrimFunc as opaque in such a case.
This happens if instead of using buffer load/stores we use tir.call_packed for computation.

cc @jwfromm @sunggg

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 28, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested a review from jwfromm March 28, 2023 22:32
Copy link
Contributor

@sunggg sunggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It would be nice to add more context about when we face such cases in the comment.

@psrivas2
Copy link
Contributor Author

Thanks for the fix! It would be nice to add more context about when we face such cases in the comment.

added a test and some context.

Copy link
Contributor

@sunggg sunggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psrivas2 Thank you!

@masahi masahi merged commit aa49fc3 into apache:unity Mar 29, 2023
tqchen pushed a commit that referenced this pull request Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores.

* Add test case for context
tqchen pushed a commit that referenced this pull request Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores.

* Add test case for context
tqchen pushed a commit that referenced this pull request Apr 1, 2023
* [Unity][Fix] Annotate TIR op pattern could have no stores.

* Add test case for context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants