[Unity] Minor updates to DataFlowBlockRewrite #14431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relax/binding_rewrite.pyis not imported by default, so we get errors likeAttributeError: <class 'tvm.runtime.object.Object'> has no attribute addif we try to pass the C++ object to pythonDataflowBlockmember variable shouldn't be optional, but it is declared withOptional<DataflowBlock> dfb_and accessed viadfb_.value()all over the places.root_fn_should be optional (e.g. whenDataFlowBlockRewriteis used inside anotherExprMutator) , but it's always updated viaroot_fn_.value()without checkingOther minor style updates that hopefully improve readability.
@ganler @tqchen