[TVMScript][Bugfix] Tuple on the RHS of AssignDoc #14452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tqchen
approved these changes
Apr 2, 2023
This PR fixes a bug in TVMScript printer handling tuples on the RHS of
an assignment, i.e.:
```python
... = (a, b, c)
^^^^^^^^^
```
The existing sugar removes the brackets surrounding `(a, b, c)`,
which makes it slightly more readable as:
```python
... = a, b, c
```
However, it overlooks a possibility where the tuple could be empty or
has only one element, i.e.
```python
... = (a, ) // Case 1: The tuple has only one element
... = () // Case 2: The tuple is empty
```
In both cases, removing brackets may lead to wrong outcome.
This patch fixes this bug.
junrushao
force-pushed
the
bugfix/2023-04-02/tuple-printing
branch
from
8356f83 to
dd06ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in TVMScript printer handling tuples on the RHS of an assignment, i.e.:
The existing sugar removes the brackets surrounding
(a, b, c), which makes it slightly more readable as:However, it overlooks a possibility where the tuple could be empty or has only one element, i.e.
In both cases, removing brackets may lead to wrong outcome.
This patch fixes this bug.