[Unity][BYOC] Fix RunCodegen pass on symbolic shape
#14472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BYOC tests using symbolic shapes have been broken since #14396. A BYOC function's return
sinforefers to a sym var defined inside that function. When a call to that is replaced by an opaquecall_dps_packed, we cannot usefunc->ret_struct_infoanymore since it refers to a sym var that's gone.It's more mysterious why
RunCodegenon symbolic shape had been working before 14396... Perhapsmainhappens to define the same-named sym var, which happens to capture the undefined variable infunc->ret_struct_info. Perhaps that is exactly what #14396 prevents.The failing cutlass test is now working but it is not tested on CI. Cublas tests will be added in #14291 which run on CI. We should also consider enabling cutlass tests on CI.
@sunggg @vinx13 @psrivas2 @Hzfengsy