Skip to content

Conversation

@masahi
Copy link
Member

@masahi masahi commented Apr 3, 2023

BYOC tests using symbolic shapes have been broken since #14396. A BYOC function's return sinfo refers to a sym var defined inside that function. When a call to that is replaced by an opaque call_dps_packed, we cannot use func->ret_struct_info anymore since it refers to a sym var that's gone.

It's more mysterious why RunCodegen on symbolic shape had been working before 14396... Perhaps main happens to define the same-named sym var, which happens to capture the undefined variable in func->ret_struct_info. Perhaps that is exactly what #14396 prevents.

The failing cutlass test is now working but it is not tested on CI. Cublas tests will be added in #14291 which run on CI. We should also consider enabling cutlass tests on CI.

@sunggg @vinx13 @psrivas2 @Hzfengsy

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@vinx13 vinx13 merged commit 751da24 into apache:unity Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants