Skip to content

[pytest] Don't return values from test_* functions #14475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kparzysz-quic merged 3 commits into from
Apr 4, 2023
Merged

[pytest] Don't return values from test_* functions #14475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0f6399
[pytest] Don't return values from test_* functions
Mar 30, 2023
6e6f5d1
Add explicit asserts
Apr 3, 2023
3f5d2c7
Use not-None in assertion
Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/python/contrib/test_hexagon/test_2d_physical_buffers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ def test_cache_shape(self, ir_module, input_layout, working_layout, output_layou
assert len(buffer.shape) == expected_physical_dimensions

def test_lower(self, schedule_args):
return tvm.lower(*schedule_args)
assert tvm.lower(*schedule_args)

@requires_hexagon_toolchain
def test_build(self, schedule_args, target_host, input_layout, working_layout, output_layout):
Expand Down
2 changes: 1 addition & 1 deletion tests/python/contrib/test_hexagon/test_maxpool2d_blocked.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def test_maxpool(self, shape_nhwc, window_size, stride, pad, dtype, target):
padding=(pad, pad, pad, pad),
dtype=dtype,
)
return output, ref_output
assert all([output is not None, ref_output is not None])
Copy link
Contributor

@Lunderberg Lunderberg Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the assert is causing spurious unit test failures, it can be removed. The test is to ensure that no exceptions are through while lowering/building, and no further assert is required.

Copy link
Contributor Author

@kparzysz-quic kparzysz-quic Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did remove it at first, but then the linter complained that output and ref_output were unused values... :|

Copy link
Contributor

@Lunderberg Lunderberg Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it. So long as the build_and_run function is called in the test, the return value should be ignoreable here.



if __name__ == "__main__":
Expand Down