Skip to content

Conversation

@Hzfengsy
Copy link
Member

@Hzfengsy Hzfengsy commented Apr 6, 2023

In the last PR #14396, we enable dynamic-shape-aware fusion in FuseOps. In this PR, we support the following FuseTIR pass for simple cases.

This PR also fixes a minor compilation warning in json_runtime.h

cc @tqchen @MasterJH5574

In the last PR apache#14396, we enable
dynamic-shape-aware fusion in FuseOps. In this PR, we support the following
FuseTIR pass for simple cases.

This PR also fixes a minor compilation warning in `json_runtime.h`
@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from MasterJH5574 and tqchen April 6, 2023 01:35
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught an issue here: https://gist.github.com/MasterJH5574/01faf389cecd4718a1f7f7129343ec3a

Not hard to fix. Personally touched base with @Hzfengsy, and we will fix this issue within this PR. Requesting change to prevent immature merge.

@Hzfengsy
Copy link
Member Author

Hzfengsy commented Apr 6, 2023

@MasterJH5574 Fixed, please take another look

Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Hzfengsy Hzfengsy merged commit a92258e into apache:unity Apr 6, 2023
@Hzfengsy Hzfengsy deleted the dyn_aware_fuse_tir branch November 5, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants