-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[microNPU][ETHOSU] Softmax int8 legalization support #14629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add support for legalizing Softmax int8 to list NPU operations as implemented in Vela.
| "reshape", | ||
| "reshape", | ||
| "contrib.ethosu.pooling", | ||
| "contrib.ethosu.binary_elementwise", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make a test more precise, I think it's also better to verify operator_type of each contrib.ethosu.binary_elementwise op. And maybe a corresponding parameter for pooling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it.
ekalda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Aleksei-grovety, looks good to me in general (bar @ilyag-grovety suggestion). Since it is a 500 line beast of an operator, I wonder if it would make sense to break it out into a separate file?
I will add a separate file for Softmax legalization. |
|
There is a problem with run microTVM demos, which consists in a greatly increased time to execute lower_to_te, I'm trying to find out the reason for this. |
60da690 to
74e8a14
Compare
74e8a14 to
dd75668
Compare
ekalda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Thanks @Aleksei-grovety and @ilyag-grovety, this is now merged! |
Add support for legalizing Softmax int8 to list NPU operations as implemented in Vela.
cc @neildhickey, @lhutton1, @ekalda, @leandron, @ilyag-grovety