Skip to content

Conversation

@Lunderberg
Copy link
Contributor

Instances of relay::Executor, relay::Runtime, and relay::backend::FunctionInfo may be inserted into a PrimFunc's attributes for bookkeeping purposes. In these flows, the function should still be able to be printed for debugging purposes.

Instances of `relay::Executor`, `relay::Runtime`, and
`relay::backend::FunctionInfo` may be inserted into a PrimFunc's
attributes for bookkeeping purposes.  In these flows, the function
should still be able to be printed for debugging purposes.
@tvm-bot
Copy link
Collaborator

tvm-bot commented May 12, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we wanted to print anything for Relay under printer/ir/ folder, because we are not maintaining Relay any more. However, I don't object if we printed it out if it helps with some usecases in production

@junrushao junrushao merged commit 318f894 into apache:main May 14, 2023
@Lunderberg
Copy link
Contributor Author

That makes sense, and agreed that it doesn't make sense to pull in portions that aren't maintained. This mainly arose while debugging some CI failures in #14778, where these types being used as attributes caused some debug print statements to fail.

Maybe it would be better to have a fallback catch-all that prints the type? That way, we avoid the relay dependency, but can still print the portions that are maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants