Skip to content

[TIR] Expand unit tests for ConvertSSA #14892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
masahi merged 2 commits into from
May 22, 2023
Merged

[TIR] Expand unit tests for ConvertSSA #14892

masahi merged 2 commits into from
May 22, 2023

Conversation

@Lunderberg
Copy link
Contributor

@Lunderberg Lunderberg commented May 19, 2023

Prior to this PR, there was a single test which invoked ConvertSSA and checked that no error was thrown. This PR adds additional test cases for nested variable definition, and for variables de-duplicated across separate function calls in an IRModule.

Of the additional tests, the behavior tested by TestDedupAutoBroadcastBuffer and TestReusedBufferParameter fails on main, and is resolved by this PR.

@Lunderberg
[TIR] Expand unit tests for ConvertSSA
f471796 
Prior to this PR, there was a single test which invoked ConvertSSA and
checked that no error was thrown.  This PR adds additional test cases
for nested variable definition, and for variables de-duplicated across
separate function calls in an `IRModule`.

Of the additional tests, the behavior tested by
`TestDedupAutoBroadcastBuffer` and `TestReusedBufferParameter` fails
on main, and is resolved by this PR.
@tvm-bot
Copy link
Collaborator

tvm-bot commented May 19, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Lunderberg
Copy link
Contributor Author

Lunderberg commented May 19, 2023

This PR is a subset of the functionality in #14862. As that PR has grown to a difficult-to-review size, I'm carving off independent chunks of it into separate PRs, after which #14862 can be rebased to a more manageable size.

tqchen
tqchen requested changes May 20, 2023
View reviewed changes
tests/python/unittest/test_tir_transform_convert_ssa.py Outdated
i1 = T.handle("int32")
with T.LetStmt(i1, var=i1):
T.evaluate(0)
with T.LetStmt(i1, var=i1):
Copy link
Member

@tqchen tqchen May 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if TVMScript support creation of non-SSA form, since future parsers could choose to do renaming, or not support such case.

It would be safer to do things with ir builder

Copy link
Contributor Author

@Lunderberg Lunderberg May 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, especially since all the before cases are malformed in some way. The IRModule-wide checks should be safe, since the duplication is introduced after parsing, but both TestReuseInSequentialLetStmt and TestReuseInNestedLetStmt should be updated to prevent future improvements to the parser from fixing them before the test runs.

Copy link
Contributor Author

@Lunderberg Lunderberg May 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are now updated so that all SSA violations are introduced outside of TVMScript.

@Lunderberg
Update tests to avoid relying on TVMScript output of non-SSA
85d88a6 
The "before" cases must have SSA violations, which is not valid in
TIR.  As such, future versions of the TVMScript parser may remove the
SSA violations in the process of parsing.  Updated unit tests
introduce SSA violations through the Python API, to avoid this
potential breakage.
@masahi masahi merged commit 5a094bc into apache:main May 22, 2023
@Lunderberg Lunderberg deleted the tir_convert_ssa_bugfixes branch May 22, 2023 12:59
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request May 30, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
0528151 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
mei-ye pushed a commit to mei-ye/tvm that referenced this pull request Jun 1, 2023
@Lunderberg @mei-ye
[TIR] Expand unit tests for ConvertSSA (apache#14892)
370090c 
* [TIR] Expand unit tests for ConvertSSA

Prior to this PR, there was a single test which invoked ConvertSSA and
checked that no error was thrown.  This PR adds additional test cases
for nested variable definition, and for variables de-duplicated across
separate function calls in an `IRModule`.

Of the additional tests, the behavior tested by
`TestDedupAutoBroadcastBuffer` and `TestReusedBufferParameter` fails
on main, and is resolved by this PR.

* Update tests to avoid relying on TVMScript output of non-SSA

The "before" cases must have SSA violations, which is not valid in
TIR.  As such, future versions of the TVMScript parser may remove the
SSA violations in the process of parsing.  Updated unit tests
introduce SSA violations through the Python API, to avoid this
potential breakage.
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 10, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
bcd3141 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 16, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
088bb0e 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 16, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
5c02044 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jun 21, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
2e54297 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jul 3, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
3710948 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jul 4, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
f694182 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jul 5, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
272b4b1 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jul 6, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
924a0f4 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Jul 7, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
1f7f6d0 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
@ysh329 ysh329 mentioned this pull request Jul 12, 2023
Closed
Lunderberg added a commit to Lunderberg/tvm that referenced this pull request Aug 8, 2023
@Lunderberg
[TIR] End-to-end tests for PrimFunc-to-PrimFunc subroutines
775742d 
The functionality tested in this commit was added across several
recent PRs, each of which tested their features in isolation.  This PR
adds unit tests to validate the end-to-end behavior of TIR subroutine
calls.

PRs building up to this point:

- TVMScript
  - apache#14889
  - apache#14915
  - apache#14919
  - apache#14941

- Functionality improvements of existing TIR passes
  - apache#14913
  - apache#14914
  - apache#14918
  - apache#14951

- Changes to the TIR lowering flow
  - apache#14942
  - apache#14985

- Codegen updates
  - apache#14958
  - apache#14901

- Compatibility updates/fixes
  - apache#14892
  - apache#14950
  - apache#14943
  - apache#14944
  - apache#14945
  - apache#14952
  - apache#14982
  - apache#14949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tqchen tqchen tqchen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Lunderberg @tvm-bot @tqchen @masahi