[RUNTIME] Update Module and Registry to use String Container #14902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Module and Registry's DLL function to use String container instead of std::string. While it is impossible to obtain a stable ABI due to the nature of c++, and it is important to keep that flexibility, it is helpful to keep small set of tvm/runtime functions to work with use a String so it is more stable across compilers.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
Member
Author
|
@tvm-bot rerun |
junrushao
approved these changes
May 31, 2023
mei-ye
pushed a commit
to mei-ye/tvm
that referenced
this pull request
Jun 1, 2023
…14902) This PR updates the Module and Registry's DLL function to use String container instead of std::string. While it is impossible to obtain a stable ABI due to the nature of c++, and it is important to keep that flexibility, it is helpful to keep small set of tvm/runtime functions to work with use a String so it is more stable across compilers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Module and Registry's DLL function to use String container instead of std::string.
While it is impossible(and un-necessary) to obtain a stable ABI due to the nature of c++, it is helpful to keep small set of tvm/runtime functions to work with use a String so it is more stable across compilers.