-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[Bug] Add typing_extensions requirement again #14960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
junrushao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I noticed the same thing recently. Perhaps we should add shutil as well given it's used in MetaSchedule and it's not heavy-weighted
|
The test failed because of below check. |
Sorry for missing that, now fixed. |
|
@tvm-bot rerun |
|
@junrushao It seems the failed tests have nothing to do with this PR, can we merge this in? maybe the failed tests will gone after rebase. |
|
I don’t have permission to merge a PR without CI being green..retriggering the pipeline |
|
Hmm it still fails |
|
The error indicate that the PR title(as in the commit message) should not end with a trailing period So changing the PR message(by rebasing it) should work. |
|
@tqchen The specific failure at the moment is: |
|
@lpdink I think your PR haven't to do with the error of "cutlass_fpA_intB_gemm", can you please try to rebase your commit onto the latest changes of the main branch and try it again? |
|
@Johnson9009 Done. Could you please re-run again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @lpdink @Johnson9009 @junrushao @tqchen
This python dependency missing problem has been reported in #14244, the same code was merged before, but strangely, the relevant changes were reverted in the latest commit. @areusch
But it can be confirmed that typing_extensions is still needed by tvmc at least: source code of tvm.meta_shedule.builder.builder
It is worth mentioning that this problem affects the tvm source code download page, at least version 0.12.0. In fact, I encountered the ModuleNotFoundError error when installing tvm from source code and trying to call tvmc. You can reproduce this error with the following command:
@leandron @driazati @junrushao