Skip to content

Conversation

@lpdink
Copy link
Contributor

@lpdink lpdink commented May 26, 2023

This python dependency missing problem has been reported in #14244, the same code was merged before, but strangely, the relevant changes were reverted in the latest commit. @areusch

But it can be confirmed that typing_extensions is still needed by tvmc at least: source code of tvm.meta_shedule.builder.builder

It is worth mentioning that this problem affects the tvm source code download page, at least version 0.12.0. In fact, I encountered the ModuleNotFoundError error when installing tvm from source code and trying to call tvmc. You can reproduce this error with the following command:

# download, compile and install.
wget https://dlcdn.apache.org/tvm/tvm-v0.12.0/apache-tvm-src-v0.12.0.tar.gz \
    && tar -zxvf apache-tvm-src-v0.12.0.tar.gz \
    && mkdir -p apache-tvm-src-v0.12.0/build \
    && cd apache-tvm-src-v0.12.0/build/ \
    && cp ../cmake/config.cmake ./ \
    && sed -i 's/set(USE_LLVM OFF)/set(USE_LLVM ON)/g' config.cmake \
    && wget https://apt.llvm.org/llvm.sh \
    && sed -i 's/add-apt-repository "\${REPO_NAME}"/add-apt-repository "\${REPO_NAME}" -y/g' llvm.sh \
    && cmake .. \
    && make -j$(nproc) \
    && python ../python/setup.py install 
# try calling tvmc
tvmc

@leandron @driazati @junrushao

@tvm-bot
Copy link
Collaborator

tvm-bot commented May 26, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: bug See #10317 for details

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I noticed the same thing recently. Perhaps we should add shutil as well given it's used in MetaSchedule and it's not heavy-weighted

@Johnson9009
Copy link
Contributor

The test failed because of below check.

[2023-05-26T04:00:25.396Z] + python3 ci/scripts/jenkins/check_pr.py --pr 14960
[2023-05-26T04:00:25.396Z] [ci/scripts/jenkins/git_utils.py:192 INFO] Running ['git', 'config', '--get', 'remote.origin.url']
[2023-05-26T04:00:25.396Z] [ci/scripts/jenkins/git_utils.py:150 INFO] Requesting GET to https://api.github.com/repos/apache/tvm/pulls/14960
[2023-05-26T04:00:25.654Z] Running checks for PR title
[2023-05-26T04:00:25.654Z]     [Bug] Add typing_extensions requirement again.
[2023-05-26T04:00:25.654Z]     Checks:
[2023-05-26T04:00:25.654Z]         [1] non_empty: PASSED
[2023-05-26T04:00:25.654Z]         [2] trailing_period: FAILED: PR must not end in a tailing '.'

@lpdink lpdink changed the title [Bug] Add typing_extensions requirement again. [Bug] Add typing_extensions requirement again Jun 21, 2023
@lpdink
Copy link
Contributor Author

lpdink commented Jun 21, 2023

The test failed because of below check.

[2023-05-26T04:00:25.396Z] + python3 ci/scripts/jenkins/check_pr.py --pr 14960
[2023-05-26T04:00:25.396Z] [ci/scripts/jenkins/git_utils.py:192 INFO] Running ['git', 'config', '--get', 'remote.origin.url']
[2023-05-26T04:00:25.396Z] [ci/scripts/jenkins/git_utils.py:150 INFO] Requesting GET to https://api.github.com/repos/apache/tvm/pulls/14960
[2023-05-26T04:00:25.654Z] Running checks for PR title
[2023-05-26T04:00:25.654Z]     [Bug] Add typing_extensions requirement again.
[2023-05-26T04:00:25.654Z]     Checks:
[2023-05-26T04:00:25.654Z]         [1] non_empty: PASSED
[2023-05-26T04:00:25.654Z]         [2] trailing_period: FAILED: PR must not end in a tailing '.'

Sorry for missing that, now fixed.

@Johnson9009
Copy link
Contributor

@tvm-bot rerun

@Johnson9009
Copy link
Contributor

@junrushao It seems the failed tests have nothing to do with this PR, can we merge this in? maybe the failed tests will gone after rebase.

@junrushao
Copy link
Member

junrushao commented Jun 25, 2023

I don’t have permission to merge a PR without CI being green..retriggering the pipeline

@junrushao
Copy link
Member

Hmm it still fails

@tqchen
Copy link
Member

tqchen commented Jun 25, 2023

The error indicate that the PR title(as in the commit message) should not end with a trailing period

So changing the PR message(by rebasing it) should work.


Add typing_extensions requirement. => Add typing_extensions requirement

@junrushao
Copy link
Member

@tqchen The specific failure at the moment is:

[2023-06-25T09:22:56.305Z] In file included from ../3rdparty/cutlass_fpA_intB_gemm/cutlass_kernels/fpA_intB_gemm/fpA_intB_gemm_fp16_int8.cu:17:
[2023-06-25T09:22:56.305Z] ../3rdparty/cutlass_fpA_intB_gemm/cutlass_kernels/fpA_intB_gemm/fpA_intB_gemm_template.h:20:10: fatal error: cutlass/gemm/device/gemm_universal_base.h: No such file or directory
[2023-06-25T09:22:56.305Z]    20 | #include "cutlass/gemm/device/gemm_universal_base.h"
[2023-06-25T09:22:56.305Z]       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[2023-06-25T09:22:56.305Z] compilation terminated.

@Johnson9009
Copy link
Contributor

@lpdink I think your PR haven't to do with the error of "cutlass_fpA_intB_gemm", can you please try to rebase your commit onto the latest changes of the main branch and try it again?

@lpdink
Copy link
Contributor Author

lpdink commented Jun 26, 2023

@Johnson9009 Done. Could you please re-run again?

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leandron leandron merged commit 904515b into apache:main Jun 26, 2023
zhuwenxi pushed a commit to zhuwenxi/tvm that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants