Skip to content

[Vulkan] Allow DeclBuffer in CodeGenSPIRV #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinx13 merged 2 commits into from
Jun 7, 2023
Merged

[Vulkan] Allow DeclBuffer in CodeGenSPIRV #15035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba9468d
[Vulkan] Allow DeclBuffer in CodeGenSPIRV
Lunderberg May 5, 2023
f3cce27
Mark unit test as requiring vulkan
Lunderberg Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/target/spirv/codegen_spirv.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,8 @@ void CodeGenSPIRV::VisitStmt_(const IfThenElseNode* op) {
builder_->StartLabel(merge_label);
}

void CodeGenSPIRV::VisitStmt_(const DeclBufferNode* op) { VisitStmt(op->body); }

void CodeGenSPIRV::VisitStmt_(const AllocateNode* op) {
ICHECK(!is_zero(op->condition));
ICHECK(!op->dtype.is_handle());
Expand Down
1 change: 1 addition & 0 deletions src/target/spirv/codegen_spirv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ class CodeGenSPIRV : public ExprFunctor<spirv::Value(const PrimExpr&)>,
void VisitStmt_(const ForNode* op) override;
void VisitStmt_(const WhileNode* op) override;
void VisitStmt_(const IfThenElseNode* op) override;
void VisitStmt_(const DeclBufferNode* op) override;
void VisitStmt_(const AllocateNode* op) override;
void VisitStmt_(const AttrStmtNode* op) override;
void VisitStmt_(const AssertStmtNode* op) override;
Expand Down
19 changes: 18 additions & 1 deletion tests/python/unittest/test_target_codegen_vulkan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import tvm.testing
from tvm import relay, te
from tvm.topi.math import cast
from tvm.script import tir as T
from tvm.script import tir as T, ir as I
from tvm.tir import TensorIntrin, IntImm, Cast, Schedule
from tvm.tir.tensor_intrin.cuda import (
WMMA_LOAD_16x16x16_F16_A_INTRIN,
Expand Down Expand Up @@ -728,5 +728,22 @@ def tensorize_load(block, dim):
tvm.testing.assert_allclose(C.numpy(), ref, rtol=1e-2, atol=1e-2)


@tvm.testing.requires_vulkan(support_required="compile-only")
def test_codegen_decl_buffer():
"""The codegen should accept DeclBuffer nodes in its input"""

@I.ir_module
class mod:
@T.prim_func
def kernel():
T.func_attr({"calling_conv": 2, "global_symbol": "kernel", "tir.noalias": True})
A_data = T.allocate([256], dtype="float32", scope="local")
A_buf = T.decl_buffer([256], dtype="float32", scope="local", data=A_data)

target = tvm.target.Target("vulkan")
vulkan_codegen = tvm.get_global_func("target.build.vulkan")
vulkan_codegen(mod, target)


if __name__ == "__main__":
tvm.testing.main()