Skip to content

[Bugfix][Relay][keras] Fix the bug about the attribute 'output_padding' in Deconv #15060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masahi merged 3 commits into from
Jun 8, 2023
Merged

[Bugfix][Relay][keras] Fix the bug about the attribute 'output_padding' in Deconv #15060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7bac9f
fix deconv about the parameter output_padding
jikechao Jun 8, 2023
5a8fa45
add test cases to capture the in deconv
jikechao Jun 8, 2023
aa66a01
Update keras.py
jikechao Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/tvm/relay/frontend/keras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,8 @@ def _convert_convolution(inexpr, keras_layer, etab, data_layout, input_shape=Non
params["groups"] = in_channels
else:
params["channels"] = n_filters
if is_deconv and keras_layer.output_padding:
params["output_padding"] = keras_layer.output_padding
if keras_layer.padding == "valid":
pass
# we insert a separate pad operator
Expand Down Expand Up @@ -507,6 +509,8 @@ def _convert_convolution3d(inexpr, keras_layer, etab, data_layout, input_shape=N
"kernel_layout": kernel_layout,
}
params["channels"] = n_filters
if is_deconv and keras_layer.output_padding:
params["output_padding"] = keras_layer.output_padding

if keras_layer.padding == "valid":
pass
Expand Down
6 changes: 6 additions & 0 deletions tests/python/frontend/keras/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,9 @@ def test_forward_conv_transpose(self, keras_mod):
data = keras_mod.layers.Input(shape=(32, 32, 128))
conv_funcs = [
keras_mod.layers.Conv2DTranspose(filters=64, kernel_size=(2, 2), padding="valid"),
keras_mod.layers.Conv2DTranspose(
filters=2, kernel_size=(3, 3), strides=(2, 2), output_padding=(1, 1)
),
]
for conv_func in conv_funcs:
x = conv_func(data)
Expand Down Expand Up @@ -619,6 +622,9 @@ def test_forward_conv3d_transpose(self, keras_mod):
filters=1, kernel_size=(3, 3, 3), padding="valid", use_bias=False
),
keras_mod.layers.Conv3DTranspose(filters=10, kernel_size=(2, 2, 2), padding="valid"),
keras_mod.layers.Conv3DTranspose(
filters=2, kernel_size=(3, 3, 3), strides=(2, 2, 2), output_padding=(1, 1, 1)
),
]
for conv_func in conv_funcs:
x = conv_func(data)
Expand Down