[NDArray] Allow creating a view from a strided array #15132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
NDArray::CreateView(...)requires the strides of the input array to be null. This makes it impossible to apply, for example, reshaping on an array which originally comes from PyTorch viafrom_dlpack.This PR relaxes the null check to allow non-null strides, as long as they are "compact". But after creating a view, the returned array no longer has strides.
This is a subset of new functionalities from another PR #14771, which ended up causing disruptive changes across the stack.
@Lunderberg @tqchen @vinx13 @yelite @sunggg