Skip to content

[AOT] Remove workaround to help resolve test flakiness #15181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhutton1 merged 1 commit into from
Jul 3, 2023
Merged

[AOT] Remove workaround to help resolve test flakiness #15181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions python/tvm/testing/aot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
# pylint: disable=use-list-literal, consider-using-with, f-string-without-interpolation
"""Common functions for AOT test cases"""
import contextlib
import sys
import datetime
import os
import pathlib
Expand Down Expand Up @@ -830,14 +829,7 @@ def run_and_check_body(base_path):
if verbose:
print("Run command:\n", run_command)

# TODO(lhutton1) This is a quick and dirty work around to help temporarily reduce
# the flakyness of the tests. Will remove once #10300 and #10314 are resolved.
try:
_subprocess_check_log_output(run_command, build_path, run_log_path)
except RuntimeError as err:
print("Failed to run the module, having a second attempt...", file=sys.stderr)
print(err, file=sys.stderr)
_subprocess_check_log_output(run_command, build_path, run_log_path)
_subprocess_check_log_output(run_command, build_path, run_log_path)

with open(run_log_path) as run_log:
assert AOT_SUCCESS_TOKEN in run_log.read()
Expand Down