[MXNET] LRN support in MXNET frontend #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srkreddy1238
requested changes
Aug 2, 2018
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
With minor change LGTM.
nnvm/python/nnvm/frontend/mxnet.py
Outdated
| new_attrs['alpha'] = attrs.get('alpha', 0.0001) | ||
| new_attrs['beta'] = attrs.get('beta', 0.75) | ||
| new_attrs['bias'] = attrs.get('knorm', 2) | ||
| new_attrs['axis'] = attrs.get('axis', 1) |
Contributor
There was a problem hiding this comment.
Could directly assign axis as mxnet never give this attribute.
Also suggest give a hint about why axis is 1.
kazum
requested changes
Aug 2, 2018
Contributor
kazum
left a comment
kazum
left a comment
There was a problem hiding this comment.
Added a minor comment. Other parts look good to me.
| test_forward_split_squeeze() | ||
| test_forward_expand_dims() | ||
| test_forward_pooling() | ||
| test_forward_lrn() No newline at end of file |
Contributor
There was a problem hiding this comment.
Add a new line at the end of file.
PariksheetPinjari909
force-pushed
the
mxnet_lrn
branch
from
ff9fbb6 to
ccf91a0
Compare
Contributor
Author
|
@kazum @srkreddy1238 Review comments are handled now. Pls check. |
srkreddy1238
approved these changes
Aug 2, 2018
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
Thanks @PariksheetPinjari909 .
LGTM.
Member
|
Thanks @PariksheetPinjari909 @kazum @srkreddy1238 , this is merged |
tqchen
pushed a commit
to tqchen/tvm
that referenced
this pull request
Aug 4, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds LRN support in MXNET frontend
@kazum @srkreddy1238 pls review.