Skip to content

[TIR] ThreadAllreduce warp-level primitive support with multi-warp #15327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tqchen merged 1 commit into from
Jul 16, 2023
Merged

[TIR] ThreadAllreduce warp-level primitive support with multi-warp #15327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tvm/tir/op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,7 @@ def tvm_storage_sync(storage_scope):
call : PrimExpr
The call expression.
"""
return call_intrin("handle", "tir.tvm_storage_sync", storage_scope)
return call_intrin("int32", "tir.tvm_storage_sync", storage_scope)


def tvm_warp_shuffle(mask, value, warp_id, width, warp_size):
Expand Down
13 changes: 7 additions & 6 deletions src/te/operation/cross_thread_reduction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,22 +181,23 @@ Stmt MakeCrossThreadReduction(const ComputeOpNode* self, const Stage& stage,
freduce_args.push_back(dummy_load);
}

// Checks for the thread.
std::vector<PrimExpr> output_preds;
if (stage->store_predicate.defined()) {
output_preds.emplace_back(stage->store_predicate);
}

for (IterVar iv : stage->leaf_iter_vars) {
if (iv->iter_type == kCommReduce) {
auto it = stage->iter_var_attrs.find(iv);
if (it != stage->iter_var_attrs.end() && (*it).second->bind_thread.defined()) {
IterVar tv = (*it).second->bind_thread;
freduce_args.push_back(tv->var);
output_preds.push_back(tv->var == make_const(tv->var->dtype, 0));
}
}
}

// Checks for the thread.
std::vector<PrimExpr> output_preds;
if (stage->store_predicate.defined()) {
output_preds.emplace_back(stage->store_predicate);
}

// Apply the existing input predicate if any.
output_preds.push_back(input_pred);

Expand Down
Loading