Skip to content

Fix Cython compile for v3.0.0 release #15346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lhutton1 wants to merge 4 commits into from
Closed

Fix Cython compile for v3.0.0 release #15346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9648ba
Fix Cython compile for v3.0.0 release
lhutton1 Jul 18, 2023
db6bef3
Upgrade the python version for windows and macos builds
lhutton1 Jul 18, 2023
9973b30
Update python version in action.yml
lhutton1 Jul 19, 2023
ab5215d
Remove version pin and set minimum version of cython in conda
lhutton1 Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ runs:
environment-file: conda/build-environment.yaml
auto-activate-base: false
use-only-tar-bz2: true
python-version: 3.7
python-version: 3.8
condarc-file: conda/condarc
- uses: conda-incubator/setup-miniconda@v2
if: steps.conda1.outcome == 'failure'
Expand All @@ -26,7 +26,7 @@ runs:
environment-file: conda/build-environment.yaml
auto-activate-base: false
use-only-tar-bz2: true
python-version: 3.7
python-version: 3.8
condarc-file: conda/condarc
- name: Conda info
shell: pwsh
Expand Down
4 changes: 2 additions & 2 deletions conda/build-environment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ channels:

# The packages to install to the environment
dependencies:
- python=3.7 # or 3.8. See https://github.com/apache/tvm/issues/8577 for more details on >= 3.9
- python=3.8 # See https://github.com/apache/tvm/issues/8577 for more details on >= 3.9
- conda-build
- git
- llvmdev >=11
- numpy
- pytest
- cython
- cython>=0.29.31
- cmake
- bzip2
- make
Expand Down
2 changes: 1 addition & 1 deletion docker/install/ubuntu_install_python_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ pip3 install --upgrade \
"Pygments>=2.4.0" \
attrs \
cloudpickle \
cython==0.29.34 \
cython \
decorator \
mypy \
numpy==1.21.* \
Expand Down
2 changes: 1 addition & 1 deletion python/tvm/_ffi/_cython/ndarray.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cdef const char* _c_str_dltensor = "dltensor"
cdef const char* _c_str_used_dltensor = "used_dltensor"


cdef void _c_dlpack_deleter(object pycaps):
cdef void _c_dlpack_deleter(object pycaps) noexcept:
cdef DLManagedTensor* dltensor
if pycapsule.PyCapsule_IsValid(pycaps, _c_str_dltensor):
dltensor = <DLManagedTensor*>pycapsule.PyCapsule_GetPointer(pycaps, _c_str_dltensor)
Expand Down