[FRONTEND][TENSORFLOW] Optimized tensorflow testcases #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Suggest to wait a while until #1505 is merged. |
Member
|
please resync the changes against current master as in #1394 |
yzhliu
requested changes
Aug 6, 2018
| return output_data | ||
|
|
||
|
|
||
| def compate_tf_with_tvm(in_data, in_name, out_name, init_global_variables=False): |
| [tf_out[0].shape, (2, batch_size, num_hidden)], | ||
| [tf_out[0].dtype, tf_out[1].dtype]) | ||
|
|
||
| if isinstance(tvm_output, list): |
yzhliu
added
status: review in progress
status: need update
Contributor
Author
|
@srkreddy1238 @yzhliu I have handled the review comments and rebased the PR, |
joyalbin
force-pushed
the
tf_test_opt
branch
2 times, most recently
from
1aad10c to
0ecd582
Compare
srkreddy1238
requested changes
Aug 9, 2018
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
Thanks @joyalbin for converting Constants to Placeholders.
Please handle the comment, otherwise LGTM.
| test_forward_multi_input() | ||
| test_forward_inception_v3() | ||
| test_forward_inception_v1() | ||
| #test_forward_inception_v1() |
Contributor
There was a problem hiding this comment.
Pls remove local changes.
yzhliu
approved these changes
Aug 10, 2018
Member
|
@srkreddy1238 would you mind take another look and approve if it is good to you? |
srkreddy1238
approved these changes
Aug 11, 2018
Contributor
srkreddy1238
left a comment
srkreddy1238
left a comment
There was a problem hiding this comment.
LGTM after rebase and CI pass.
yzhliu
added
status: accepted
and removed
status: need update
Member
|
Thanks, this is now merged. |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
* [NNVM][TENSORFLOW] Optimized tensorflow testcases * Replace Constants with Placeholder * Review comment fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove the code duplication in tensoflow testcases