Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/relax/ir/dataflow_matcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -831,10 +831,19 @@ class PatternRewriter : ExprMutator {
}

BindingBlock VisitBindingBlock_(const DataflowBlockNode* block_node) final {
if (!ctx_) {
return ExprMutator::VisitBindingBlock_(block_node);
if (ctx_) {
return RewriteDataflowBlockFixedPoint(GetRef<DataflowBlock>(block_node));
}

DataflowBlock prev = GetRef<DataflowBlock>(block_node);
while (true) {
DataflowBlock next = Downcast<DataflowBlock>(ExprMutator::VisitBindingBlock_(prev.get()));
if (StructuralEqual()(prev, next)) {
return std::move(next);
} else {
prev = next;
}
}
return RewriteDataflowBlockFixedPoint(GetRef<DataflowBlock>(block_node));
}

private:
Expand Down
48 changes: 48 additions & 0 deletions tests/python/relax/test_dataflow_pattern.py
Original file line number Diff line number Diff line change
Expand Up @@ -1318,5 +1318,53 @@ def rewriter(_expr, matches):
tvm.ir.assert_structural_equal(after, expected)


def test_repeated_pattern_match():
"""rewrite_call should iterate until convergence"""

@R.function(private=True)
def before(
x: R.Tensor((1024,)),
y: R.Tensor((1024,)),
z: R.Tensor((1024,)),
):
with R.dataflow():
a = R.add(x, y)
b = R.add(a, z)
out = R.multiply(b, R.const(5.0))
R.output(out)
return out

@R.function(private=True)
def expected(
x: R.Tensor((1024,)),
y: R.Tensor((1024,)),
z: R.Tensor((1024,)),
):
with R.dataflow():
x = R.multiply(x, R.const(5.0))
y = R.multiply(y, R.const(5.0))
a = R.add(x, y)
z = R.multiply(z, R.const(5.0))
b = R.add(a, z)
R.output(b)
return b

pattern_add_lhs = wildcard()
pattern_add_rhs = wildcard()
pattern_add = is_op("relax.add")(pattern_add_lhs, pattern_add_rhs)

mul_const = is_const()
pattern_mul = is_op("relax.multiply")(pattern_add, mul_const)

pattern = pattern_mul

def rewriter(_expr, matches):
const = matches[mul_const]
return (matches[pattern_add_lhs] * const) + (matches[pattern_add_rhs] * const)

after = rewrite_call(pattern, rewriter, before)
tvm.ir.assert_structural_equal(after, expected)


if __name__ == "__main__":
tvm.testing.main()