Skip to content

[TVMScript] Create loop var with min_val dtype in for frame #15547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hzfengsy merged 1 commit into from
Aug 15, 2023
Merged

[TVMScript] Create loop var with min_val dtype in for frame #15547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/script/ir_builder/tir/ir.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ Array<Var> Remap(String kinds, Array<PrimExpr> bindings, DataType dtype) {
PrimExpr extent = arith::Analyzer().Simplify(stop - start); \
ObjectPtr<ForFrameNode> n = make_object<ForFrameNode>(); \
int bits = std::max(min.dtype().bits(), extent.dtype().bits()); \
n->vars = {Var("v", DataType::Int(bits))}; \
n->vars = {Var("v", DataType(min.dtype().code(), bits, 1))}; \
n->doms = {Range::FromMinExtent(min, extent)}; \
n->f_make_for_loop = [annotations](Array<Var> vars, Array<Range> doms, tvm::tir::Stmt body) { \
ICHECK_EQ(vars.size(), 1); \
Expand All @@ -344,7 +344,7 @@ ForFrame ThreadBinding(PrimExpr start, PrimExpr stop, String thread,
PrimExpr extent = arith::Analyzer().Simplify(stop - start);
ObjectPtr<ForFrameNode> n = make_object<ForFrameNode>();
int bits = std::max(min.dtype().bits(), extent.dtype().bits());
n->vars = {Var("v", DataType::Int(bits))};
n->vars = {Var("v", DataType(min.dtype().code(), bits, 1))};
n->doms = {Range::FromMinExtent(min, extent)};
n->f_make_for_loop = [annotations, thread](Array<Var> vars, Array<Range> doms, Stmt body) -> For {
ICHECK_EQ(vars.size(), 1);
Expand Down
20 changes: 20 additions & 0 deletions tests/python/unittest/test_tvmscript_ir_builder_tir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,26 @@ def test_ir_builder_tir_for():
assert_structural_equal(for_actual, for_expected, map_free_vars=True)


def test_ir_builder_tir_for_uint():
with IRBuilder() as ib:
with T.serial(tir.const(128, "uint32")) as a:
T.evaluate(0)

# the for generated by IRBuilder
for_actual = ib.get()

for_expected = tir.For(
loop_var=tir.Var("", "uint32"),
min_val=tir.const(0, "uint32"),
extent=tir.const(128, "uint32"),
kind=tir.ForKind.SERIAL,
body=tir.Evaluate(0),
)

# Check if the generated ir is expected
assert_structural_equal(for_actual, for_expected, map_free_vars=True)


def test_ir_builder_tir_assert():
with IRBuilder() as ib:
with T.Assert(T.int32() == 0, message="a is 0"):
Expand Down