Skip to content

Conversation

@leiwen83
Copy link
Contributor

Since current relax not support value range binding for dynamic shape. It is meaningless to do the real profile, as the result would be always inf.

Since current relax not support value range binding for dynamic shape.
It is meaningless to do the real profile, as the result would be
always inf.

Signed-off-by: Lei Wen <wenlei03@qiyi.com>
@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 16, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@Hzfengsy Hzfengsy changed the title don't do actual profile when input is dynamic shape [Unity] don't do actual profile when input is dynamic shape Aug 16, 2023
@Hzfengsy
Copy link
Member

cc @masahi

@masahi
Copy link
Member

masahi commented Aug 16, 2023

please send this to main.

@leiwen83
Copy link
Contributor Author

I also want to know whether we could support pass like value range for the dynamic shape?

So that BYOC like tensorRT take range to do further opt? tensorRT opt the model use [min, best, max] range.

Copy link
Member

@masahi masahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as "Request changes" to prevent this from merging into unity (not to repeat a bad practice like #14275).

@leiwen83 leiwen83 closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants