[FRONTEND][DARKNET]LSTM and GRU support #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@PariksheetPinjari909 @srkreddy1238 @yzhliu could you please review this PR. |
PariksheetPinjari909
suggested changes
Aug 13, 2018
Contributor
PariksheetPinjari909
left a comment
PariksheetPinjari909
left a comment
There was a problem hiding this comment.
Others looks LGTM
nnvm/python/nnvm/frontend/darknet.py
Outdated
|
|
||
| elif LAYERTYPE.GRU == layer.type: | ||
| if layer.steps > 1: | ||
| raise NotImplementedError("Currenty support only single step GRU") |
Contributor
There was a problem hiding this comment.
pls correct spell.
nnvm/python/nnvm/frontend/darknet.py
Outdated
|
|
||
| elif LAYERTYPE.LSTM == layer.type: | ||
| if layer.steps > 1: | ||
| raise NotImplementedError("Currenty support only single step GRU") |
Contributor
There was a problem hiding this comment.
pls correct spell
| test_forward_crnn() | ||
| test_forward_lstm() | ||
| test_forward_gru() | ||
| test_forward_activation_logistic() No newline at end of file |
siju-samuel
force-pushed
the
darknet_lstm_gru
branch
from
0d26194 to
6697ca8
Compare
Member
Author
|
@PariksheetPinjari909 Thanks for the review. I updated the code. Please check again. TIA. |
PariksheetPinjari909
approved these changes
Aug 14, 2018
Member
|
Thanks @siju-samuel @PariksheetPinjari909 , this is now merged |
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the RNN operators are completed for Darknet
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.