Skip to content

[TFLite][Frontend] Support quantized NOT_EQUAL #15769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandron merged 3 commits into from
Sep 18, 2023
Merged

[TFLite][Frontend] Support quantized NOT_EQUAL #15769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f9755b
make not_equal quantized
tlopex Sep 17, 2023
046d922
add tests to quantized not_equal
tlopex Sep 17, 2023
217a2c1
add quantized not_equal
tlopex Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions python/tvm/relay/frontend/tflite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,11 +1500,7 @@ def convert_equal(self, op):

def convert_not_equal(self, op):
"""Convert TFLite NOT_EQUAL"""
if self.is_quantized(op):
raise tvm.error.OpNotImplemented(
"TFlite quantized NOT_EQUAL operator is not supported yet."
)
return self._convert_elemwise(_op.not_equal, op)
return self._convert_elemwise(_op.not_equal, op, self.is_quantized(op), comparison_op=True)

def _convert_logical_binary(self, relay_op, op):
"""Generic method to convert logical binary ops"""
Expand Down
14 changes: 12 additions & 2 deletions tests/python/frontend/tflite/test_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2728,9 +2728,17 @@ def _test_equal(data, fused_activation_function=None, quantized=False, qnn_op=No
# ---------


def _test_not_equal(data):
def _test_not_equal(data, fused_activation_function=None, quantized=False, qnn_op=None):
"""One iteration of not_equal"""
return _test_elemwise(math_ops.not_equal, data)
return _test_elemwise(
math_ops.not_equal,
data,
fused_activation_function,
quantized,
qnn_op,
same_qnn_params=True,
comparison_op=True,
)


#######################################################################
Expand Down Expand Up @@ -2833,6 +2841,7 @@ def _test_elemwise_qnn_out_range(qnn_op):
_test_floor_divide: (-150, 150),
_test_less: (-150, 150),
_test_floor_mod: (-150, 150),
_test_not_equal: (-150, 150),
}

return qnn_out_range[qnn_op]
Expand Down Expand Up @@ -2873,6 +2882,7 @@ def test_all_elemwise():
_test_forward_elemwise(_test_equal)
_test_forward_elemwise_quantized(_test_equal)
_test_forward_elemwise(_test_not_equal)
_test_forward_elemwise_quantized(_test_not_equal)
if package_version.parse(tf.VERSION) >= package_version.parse("1.14.0"):
_test_forward_elemwise(_test_floor_divide)
_test_forward_elemwise_quantized(_test_floor_divide)
Expand Down