[Fix][Unity] Fix TVMError when loading ONNX model with CumSum operator #15804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@dmilosevic252 Thanks for your fixing. Could you add a regression test? |
Contributor
Author
|
@jikechao Thank you for the feedback! I added a regression test. |
Hzfengsy
reviewed
Oct 3, 2023
| bias=False, | ||
| per_channel_quantization=False, | ||
| ): | ||
|
|
Member
There was a problem hiding this comment.
Please revert the lines of changes to keep the PR clear :)
Contributor
Author
There was a problem hiding this comment.
The line changes have been reverted. Thank you for the feedback!
Hzfengsy
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default value 0 for the axis variable, if the value has not been previously set.
This is a code patch for fixing this issue: #15728